Open
Conversation
jamieadieze
reviewed
Aug 29, 2023
There was a problem hiding this comment.
What was done well:
- Really good use of different types of documentation throughout the script
- Really explicit code - it is easy to see what purpose each line of code serves in regards to the overall project
- Good naming - variable and function names were relevant and long enough to inform myself and other reviewers the purpose of certain functions, but not overly long.
Critiques:
- If adhering to the PEP8 standard, then some line did go over the 79 character limit. Would suggest using backwards slash "" to break lines up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.