Skip to content

Submission - James#6

Open
jdc338 wants to merge 1 commit intoalexnaylor99:mainfrom
jdc338:main
Open

Submission - James#6
jdc338 wants to merge 1 commit intoalexnaylor99:mainfrom
jdc338:main

Conversation

@jdc338
Copy link
Collaborator

@jdc338 jdc338 commented Aug 25, 2023

No description provided.

@jdc338 jdc338 changed the title Final Submission - JC Submission - James Aug 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was done well:

  • Really good use of different types of documentation throughout the script
  • Really explicit code - it is easy to see what purpose each line of code serves in regards to the overall project
  • Good naming - variable and function names were relevant and long enough to inform myself and other reviewers the purpose of certain functions, but not overly long.

Critiques:

  • If adhering to the PEP8 standard, then some line did go over the 79 character limit. Would suggest using backwards slash "" to break lines up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants